Skip site navigation (1) Skip section navigation (2)

pgsql: Fix failure to think clearly about encoding conversion errors in

From: tgl(at)svr1(dot)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix failure to think clearly about encoding conversion errors in
Date: 2004-10-29 19:18:25
Message-ID: 20041029191825.487C03A3B48@svr1.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Fix failure to think clearly about encoding conversion errors in COPY.
We can't regurgitate the unconverted string as I first thought, because
the elog.c mechanisms will assume the error message data is in the server
encoding and attempt a reverse conversion.  Eventually it might be worth
providing a short-circuit path to support this, but for now the simplest
solution is to abandon trying to report back the line contents after a
conversion failure.  Per bug report from Sil Lee, 27-Oct-2004.

Modified Files:
--------------
    pgsql/src/backend/commands:
        copy.c (r1.232 -> r1.233)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/copy.c.diff?r1=1.232&r2=1.233)

pgsql-committers by date

Next:From: Bruce MomjianDate: 2004-10-29 19:30:04
Subject: pgsql: No need to set errorMessage length --- already set in goto
Previous:From: Bruce MomjianDate: 2004-10-29 17:53:14
Subject: pgsql: Set errorMessage length in PQrequestCancel() in all places.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group