Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] src/timezone/pgtz __imp__my_exec_path

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Reini Urban <rurban(at)x-ray(dot)at>
Cc: Magnus Hagander <mha(at)sollentuna(dot)net>,pgsql-hackers(at)postgresql(dot)org, pgsql-cygwin(at)postgresql(dot)org
Subject: Re: [HACKERS] src/timezone/pgtz __imp__my_exec_path
Date: 2004-10-27 19:13:44
Message-ID: 200410271913.i9RJDic11007@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-cygwinpgsql-hackers
Reini Urban wrote:
> Magnus Hagander schrieb:
> >>beta4 - cygwin:
> >>postgres.exe fails to build, because __imp__my_exec_path from 
> >>src/timezone/pgtz.o cannot be resolved. previously it was not 
> >>imported.
> > 
> > This could be related to the patch that went in last weekend to fix
> > compiles on Win32. DLLIMPORT was added to the header. If the Makefile
> > did not change, then that is your problem - that patch changed botht he
> > makefile and the header. See
> > http://archives.postgresql.org/pgsql-committers/2004-10/msg00321.php
> > 
> > Does CYGWIN perhaps need the same Makefile patch?
> 
> You only patched your Makefile.win32, not Makefile.cygwin. That's it. It 
> builds fine now.
> 
> Please add also
> 
> ifneq (,$(findstring timezone,$(subdir)))
> override CPPFLAGS+= -DBUILDING_DLL
> endif
> 

OK, patch applied.  I also fixed the ecpg test in Makefile.win32.

> to the Makefile.cygwin.
> Without it doesn't break just contrib/tsearch, it even breaks cygwin 
> postmaster.
> 
> Maybe all win32.mak and bcc32.mak must also be checked. Does anybody do 
> the msvc/borland suites?

Those don't build the backend, only libpq and psql.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-cygwin by date

Next:From: michael.schwartzDate: 2004-10-27 23:36:35
Subject: instructions are useful, but lacking
Previous:From: Magnus HaganderDate: 2004-10-27 18:25:45
Subject: Re: [HACKERS] src/timezone/pgtz __imp__my_exec_path

pgsql-hackers by date

Next:From: Greg StarkDate: 2004-10-27 19:39:16
Subject: Re: Should bgwriter log checkpoint start/end?
Previous:From: Bruce MomjianDate: 2004-10-27 18:53:26
Subject: Re: Unixware 714 pthreads

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group