Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Need for DLLINIT in Makefile.shlib

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Reini Urban <rurban(at)x-ray(dot)at>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>,PostgreSQL Cygwin mailing list <pgsql-cygwin(at)postgresql(dot)org>,PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: [HACKERS] Need for DLLINIT in Makefile.shlib
Date: 2004-10-12 22:19:03
Message-ID: 200410122219.i9CMJ3I08797@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-cygwinpgsql-hackerspgsql-hackers-win32
OK, I removed DLLINIT from Cygwin Makefile.shlib so it is now the same
as Win32.  I don't see any easy way to use ifeq to test multiple port
strings so I didn't merge the duplicate Win32 and Cygwin Makefile
actions.

---------------------------------------------------------------------------

Reini Urban wrote:
> Jason Tishler schrieb:
> > On Tue, Oct 12, 2004 at 01:37:48AM +0200, Reini Urban wrote:
> >>Bruce Momjian schrieb:
> >>
> >>>I am curious why Cygwin needs DLLINIT in Makefile.shlib, and Win32
> >>>doesn't:
> >>>
> >>>	[snip]
> >>>
> >>>The only difference I see is that Cygwin uses $(DLLINIT) while Win32
> >>>does not.  Is that correct?  Why?
> >>>
> >>>Both set DLLINIT in their makefiles:
> >>>
> >>>	DLLINIT = $(top_builddir)/src/utils/dllinit.o
> >>>
> >>>Could they be merged into a single snipped of code?
> >>
> >>Good point!  Out of my head: I don't think that we (cygwin) don't need
> >>that anymore.  With newer binutils it should get autogenerated. But
> >>I'll have to test before you can remove that dir.
> > 
> > 
> > I concur with Reini.  The DLLINIT stuff is a vestige from b20.1.  FWIW,
> > I attempted to remove it 3 - 4 years ago, but was unsuccessful...
> 
> I build successfully without this DLLINIT yestreday, and ran then into 
> the one remaining regression error, which I reported before (during 
> inserting some polygons in the parallel suite).
> 
> But this is for sure not related, so you can safely clean that mess up, 
> (remove that dir) and merge the win32 and cygwin makefile recipe.
> -- 
> Reini Urban
> http://xarch.tu-graz.ac.at/home/rurban/
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
> 
>                http://www.postgresql.org/docs/faqs/FAQ.html
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-cygwin by date

Next:From: Noreen JasterDate: 2004-10-12 23:50:59
Subject: Re: Static build of libpq fails
Previous:From: Reini UrbanDate: 2004-10-12 17:04:41
Subject: Re: [HACKERS] Need for DLLINIT in Makefile.shlib

pgsql-hackers by date

Next:From: Gaetano MendolaDate: 2004-10-12 22:28:06
Subject: Re: plans for bitmap indexes?
Previous:From: Andreas PflugDate: 2004-10-12 21:59:31
Subject: Re: Required permissions for data directory

pgsql-hackers-win32 by date

Next:From: Noreen JasterDate: 2004-10-12 23:50:59
Subject: Re: Static build of libpq fails
Previous:From: Reini UrbanDate: 2004-10-12 17:04:41
Subject: Re: [HACKERS] Need for DLLINIT in Makefile.shlib

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group