Re: open item: tablespace handing in pg_dump/pg_restore

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Greg Stark <gsstark(at)mit(dot)edu>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: open item: tablespace handing in pg_dump/pg_restore
Date: 2004-10-12 01:06:26
Message-ID: 200410120106.i9C16QJ18109@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-cygwin pgsql-hackers pgsql-hackers-win32

Greg Stark wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>
> > OK, I have applied the following patch that uses Cygwin native symlink()
> > instead of the Win32 junctions. The reason for this is that Cygwin
> > symlinks work on Win95/98/ME where junction points do not
>
> Is this really a Win95/98/ME vs NT distinction or a FAT32 vs NTFS distinction?
> In which case does an NT machine that happens to be using a FAT32 file system
> have the same problem?

I believe it is OS, not file system.
>
> > and we have no way to know what system will be running the Cygwin binaries
>
> Is there a reason to make this a compile-time decision? Can't it just try to
> make a junction and if it fails then use the Cygwin symlink?

Yes, if we feel like probing for the Windows OS during runtime. I don't
think it is worth it.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-cygwin by date

  From Date Subject
Next Message Jason Tishler 2004-10-12 11:30:00 Re: [HACKERS] Need for DLLINIT in Makefile.shlib
Previous Message Greg Stark 2004-10-12 00:57:20 Re: open item: tablespace handing in pg_dump/pg_restore

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-10-12 01:07:12 Re: Unit testing
Previous Message Gavin Sherry 2004-10-12 01:04:23 Re: Unit testing

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Bruce Momjian 2004-10-12 01:08:21 Re: Static build of libpq fails
Previous Message Greg Stark 2004-10-12 00:57:20 Re: open item: tablespace handing in pg_dump/pg_restore