Skip site navigation (1) Skip section navigation (2)

Re: Win32 Version patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Magnus Hagander <mha(at)sollentuna(dot)net>
Cc: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>,PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Win32 Version patch
Date: 2004-10-05 19:31:25
Message-ID: 200410051931.i95JVP002201@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Patch applied.  Thanks.

I made the wording correction suggested by Dave Page.

Cleaned up patch attached.  I think the impact is minimal as I renamed
some things and moved the binary description up to the top of the
Makefile so it looks like a comment.

---------------------------------------------------------------------------


Magnus Hagander wrote:
> > Dave Page wrote:
> > > Evening committers,
> > > 
> > > Any ideas when Magnus' win32 version numbering patch is 
> > likely to get 
> > > applied?
> > 
> > Good question.  Last I saw it it was quite large.  Magnus, 
> > would you post a new version so we can look it over again.  I 
> > have no problem with the binary file you suggested.
> 
> Not really, since I haven't changed anything. But I can send the same
> patch again. Last time I sent it there were no comments, so I knew of
> nothing further to change. If there are more changes wanted, just tell
> me what to change...
> 
> The only remaining discussion I recall was possibly moving of the ico
> file to a different directory. Which I said I'd happily leave up to the
> committers :-) If you tell me where you want it I can of course create a
> new patch which uses those dirs... But I don't feel up to deciding about
> new directories myself ;-)
> 
> //Magnus
> 

Content-Description: win32ver_2.patch

[ Attachment, skipping... ]

Content-Description: pgsql.ico

[ Attachment, skipping... ]

Content-Description: win32ver.rc

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-patches by date

Next:From: Tom LaneDate: 2004-10-05 21:48:27
Subject: Re: libpq and prepared statements progress for 8.0
Previous:From: David WheelerDate: 2004-10-05 17:31:53
Subject: Re: libpq and prepared statements progress for 8.0

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group