Re: More pgindent bizarreness

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: More pgindent bizarreness
Date: 2004-09-30 20:48:31
Message-ID: 200409302048.i8UKmVP04156@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Or do you mean here?
>
> Both, but the multi-line case with two different indent levels is
> particularly strange.
>
> You're right that this particular code is new in 8.0. (Looks around...)
> struct f_smgr in smgr.c is a comparable case, and it seems to have been
> weirdly indented right along, so maybe it's an old bug.

Yes, that is what I am thinking. I have worked around other bugs in the
C code before by doing things with the shell script though this problem
seems hard to clean up with a shell script. I found GNU indent to be
even harder to fix.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2004-09-30 20:50:37 Re: Bug in Beta3 with parser?
Previous Message Zhenchang Xing 2004-09-30 20:43:30 output branches before infinite recursion using connectby()?