Skip site navigation (1) Skip section navigation (2)

Re: [pgsql-hackers-win32] Testing needed for recent tablespace

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: markir(at)coretech(dot)co(dot)nz
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers-win32(at)postgresql(dot)org,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [pgsql-hackers-win32] Testing needed for recent tablespace
Date: 2004-08-31 11:31:36
Message-ID: 200408311131.i7VBVaj28094@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-hackers-win32
Yep, related.  There was a typo in win32.h for lstat that was exposed by
the new tablespace changes.  I also added the proper parameters rather
than just redefining the symbol.

Attached is the patch.  Do we need to repackage beta2 for this?  Tom did
ask for Win32 testers two days ago and it is just being tested now.

---------------------------------------------------------------------------

markir(at)coretech(dot)co(dot)nz wrote:
> Hmmm... not entirely sure if this is related - but I get a compile failure on
> win2000 pro :
> 
> gcc -O2 -fno-strict-aliasing -Wall -Wmissing-prototypes -Wmissing-declarations
> -L../../src/port -L/usr/local/lib  -o postgres.exe
> -Wl,--base-file,postgres.base postgres.exp access/SUBSYS.o bootstrap/SUBSYS.o
> catalog/SUBSYS.o parser/SUBSYS.o commands/SUBSYS.o executor/SUBSYS.o
> lib/SUBSYS.o libpq/SUBSYS.o main/SUBSYS.o nodes/SUBSYS.o optimizer/SUBSYS.o
> port/SUBSYS.o postmaster/SUBSYS.o regex/SUBSYS.o rewrite/SUBSYS.o
> storage/SUBSYS.o tcop/SUBSYS.o utils/SUBSYS.o ../../src/timezone/SUBSYS.o
> -lpgport -lz -lwsock32 -lm  -lws2_32
> commands/SUBSYS.o(.text+0x2a827):tablespace.c: undefined reference to `slat'
> make[2]: *** [postgres] Error 1
> make[2]: Leaving directory
> `/home/Administrator/develop/c/postgresql-8.0.0beta1/src/backend'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory
> `/home/Administrator/develop/c/postgresql-8.0.0beta1/src'
> make: *** [all] Error 2
> 
> regards
> 
> Mark
> 
> Quoting Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> 
> > Would someone check that I didn't break the Windows port with this
> > recent commit:
> >
> 
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
> 
>                http://www.postgresql.org/docs/faqs/FAQ.html
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-hackers by date

Next:From: Jim ButtafuocoDate: 2004-08-31 11:36:41
Subject: Re: beta 1 failed on linux mipsel
Previous:From: Shinji TeragaitoDate: 2004-08-31 11:00:14
Subject: Re: [PATCHES] HP-UX PA-RISC/Itanium 64-bit Patch and HP-UX 11.23 Patch

pgsql-hackers-win32 by date

Next:From: Magnus HaganderDate: 2004-08-31 17:34:04
Subject: Re: Testing needed for recent tablespace hacking
Previous:From: markirDate: 2004-08-31 07:22:01
Subject: Re: Testing needed for recent tablespace

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group