On Sat, 21 Aug 2004, Bruce Momjian wrote:
> Tom Lane wrote:
>> momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian) writes:
>>> Add ALTER INDEX, particularly for moving tablespaces.
>> This patch is a perfect example of why unreviewed patches should not
>> go in during beta.
>> So far I have noticed the following problems with it:
>> * Added reference page wasn't linked into the docs build.
>> * Added a field to struct AlterTableStmt, but did not do the necessary
>> housekeeping for extending a Node (eg, copyfuncs and equalfuncs
>> adjustments), nor make sure the field is validly set in every place
>> an AlterTableStmt is constructed.
>> * ALTER INDEX RENAME doesn't actually work.
>> regression=# alter index foo_pkey rename to zzz;
>> ERROR: unrecognized rename stmt type: 9
>> That's not counting the problem someone else already reported with
>> incorrect tab-completion.
> Yes, you are right. Because Gavin is "Mr Tablespaces" I didn't give it
> a thorough read.
> FYI, I just fixed the tab completion problem.
Considering point 3 seems a wee bit critical, at least to me, should the
patch be removed and postponed for a non-Beta period?
Marc G. Fournier Hub.Org Networking Services (http://www.hub.org)
Email: scrappy(at)hub(dot)org Yahoo!: yscrappy ICQ: 7615664
In response to
pgsql-committers by date
|Next:||From: Tom Lane||Date: 2004-08-21 23:43:23|
|Subject: Re: pgsql-server: Add ALTER INDEX, particularly for moving |
|Previous:||From: User Dpage||Date: 2004-08-21 20:40:37|
|Subject: pginstaller - pginst: Install for all users wheneever possible, rather |