From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql-server: Add ALTER INDEX, particularly for moving |
Date: | 2004-08-21 18:46:54 |
Message-ID: | 200408211846.i7LIks022953@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Tom Lane wrote:
> momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian) writes:
> > Add ALTER INDEX, particularly for moving tablespaces.
>
> This patch is a perfect example of why unreviewed patches should not
> go in during beta.
>
> So far I have noticed the following problems with it:
>
> * Added reference page wasn't linked into the docs build.
>
> * Added a field to struct AlterTableStmt, but did not do the necessary
> housekeeping for extending a Node (eg, copyfuncs and equalfuncs
> adjustments), nor make sure the field is validly set in every place
> an AlterTableStmt is constructed.
>
> * ALTER INDEX RENAME doesn't actually work.
>
> regression=# alter index foo_pkey rename to zzz;
> ERROR: unrecognized rename stmt type: 9
>
> That's not counting the problem someone else already reported with
> incorrect tab-completion.
Yes, you are right. Because Gavin is "Mr Tablespaces" I didn't give it
a thorough read.
FYI, I just fixed the tab completion problem.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | User Dpage | 2004-08-21 20:39:17 | pginstaller - pginst: %SESSIONNAME% may not exist on NT4 without |
Previous Message | Bruce Momjian | 2004-08-21 18:45:59 | pgsql-server: Fix tab completion for ALTER INDEX. |