Gavin Sherry wrote:
> On Fri, 20 Aug 2004, Tom Lane wrote:
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > No, but it is a missing capability many will complain about. I can
> > > easily remove it. I saw no one comment when I added it to the patches
> > > queue.
> > I hadn't seen you add it to the patches queue ...
> > I did see Gavin's submission but did not yet have time to look at the
> > details. What does it *do* exactly --- simply allow INDEX as a
> > substitute for TABLE in the syntax, or more? I'm not thrilled at the
> > idea of adding a lot of duplicate coding for this.
> I tried to avoid any duplication. The patch still uses all the ALTER TABLE
> code. Its just a grammar modification and some setting of completion tags.
> That being said, I felt obliged to provide at patch when I started hearing
> noise about ALTER TABLE <index name> being a bit of a hack -- which it is.
The issue was that few people currently modify indexes because in the
past you could only rename an index or change its owner. With
tablespaces, we are going to have lots more people moving indexes
around, and I think people were getting confused because there was no
ALTER INDEX to move them.
I can still back it out and leave it for 8.1 but it probably will reduce
confusion and perhaps need for an FAQ, "How do I move an index between
FYI, I just fixed a typo in the ALTER INDEX manual page that mentioned
INDEXSPACE instead of TABLESPACE.
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
In response to
pgsql-patches by date
|Next:||From: Bruce Momjian||Date: 2004-08-20 16:06:35|
|Subject: Re: pg_restore recognizing $-quotes|
|Previous:||From: Gavin Sherry||Date: 2004-08-20 05:32:12|
|Subject: Re: ALTER INDEX |