| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] 8.0 libpq: missing get_home_path() |
| Date: | 2004-08-19 00:01:19 |
| Message-ID: | 200408190001.i7J01Ji12671@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
OK, patch attached and applied. I also updated the docs.
---------------------------------------------------------------------------
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I need to call canonicalize_path() in the macro.
>
> There is only one use of get_home_path in libpq. Lose it and do
> a direct getenv(HOMEDIR). You do not really need to do a
> canonicalize_path there; it'd be sufficient to insert the appropriate
> directory separator ('/' or '\') when forming pgpassfile just below.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| Attachment | Content-Type | Size |
|---|---|---|
| unknown_filename | text/plain | 2.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christopher Kings-Lynne | 2004-08-19 01:31:04 | Re: tablespace and sequences? |
| Previous Message | Gavin Sherry | 2004-08-18 23:40:28 | Re: Tablespace and cpu costs |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2004-08-19 00:01:36 | Re: 8.0 Beta 1 // Environment Vars // .pgpass |
| Previous Message | Philip Warner | 2004-08-18 22:20:13 | Re: pg_restore recognizing $-quotes |