Skip site navigation (1) Skip section navigation (2)

Re: ALTER INDEX

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>
Cc: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>,pgsql-patches(at)postgresql(dot)org
Subject: Re: ALTER INDEX
Date: 2004-08-18 03:28:27
Message-ID: 200408180328.i7I3SRT01498@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Your adjustment has been added to the PostgreSQL unapplied patches list at:

	http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------


Stefan Kaltenbrunner wrote:
> Gavin Sherry wrote:
> 
> 
> > Index: src/bin/psql/tab-complete.c
> > ===================================================================
> > RCS file: /usr/local/cvsroot/pgsql-server/src/bin/psql/tab-complete.c,v
> > retrieving revision 1.109
> > diff -2 -c -r1.109 tab-complete.c
> > *** src/bin/psql/tab-complete.c	28 Jul 2004 14:23:30 -0000	1.109
> > --- src/bin/psql/tab-complete.c	13 Aug 2004 06:34:55 -0000
> > ***************
> > *** 633,637 ****
> >   	{
> >   		static const char *const list_ALTER[] =
> > ! 		{"DATABASE", "GROUP", "SCHEMA", "TABLE", "TRIGGER", "USER", NULL};
> >   
> >   		COMPLETE_WITH_LIST(list_ALTER);
> > --- 633,638 ----
> >   	{
> >   		static const char *const list_ALTER[] =
> > ! 		{"DATABASE", "GROUP", "SCHEMA", "TABLE", "TRIGGER", "USER", "INDEX",
> > ! 			 NULL};
> >   
> >   		COMPLETE_WITH_LIST(list_ALTER);
> > ***************
> > *** 647,650 ****
> > --- 648,661 ----
> >   		COMPLETE_WITH_LIST(list_ALTERDATABASE);
> >   	}
> > + 	/* ALTER INDEX <name> */
> > + 	else if (pg_strcasecmp(prev3_wd, "ALTER") == 0 &&
> > +              pg_strcasecmp(prev2_wd, "INDEX") == 0)
> > +     {
> > +         static const char *const list_ALTERDATABASE[] =
> > +         {"SET TABLESPACE", "OWNER TO", "RENAME TO", NULL};
> > +                                                                                 
> > +         COMPLETE_WITH_LIST(list_ALTERDATABASE);
> 
> minor issue/nit(?): reusing list_ALTERDATABASE for the ALTER INDEX part 
> looks a little strange ...
> 
> 
> Stefan(who could really need some feedback on his own tab-complete patch 
> *g*)
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2004-08-18 03:37:21
Subject: Re: Compiling libpq with VC6
Previous:From: Bruce MomjianDate: 2004-08-18 03:26:18
Subject: Re: Add GUC_REPORT to server_encoding, integer_datetimes

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group