8.0.0 beta 1, contrib/dbsize, GetDatabasePath wrong

From: Matthew L Daniel <mdaniel(at)scdi(dot)com>
To: pgsql-bugs(at)postgresql(dot)org
Subject: 8.0.0 beta 1, contrib/dbsize, GetDatabasePath wrong
Date: 2004-08-11 21:29:32
Message-ID: 20040811212932.GP7619@cafebabe.intra
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

dbsize.c was not updated to use the new tablespace-aware function.

I am not well versed enough with the new function to know if "GLOBAL..."
was the correct default for what dbsize is trying to do. I just thought
you guys might want to know.

Thanks for the WORLD'S GREATEST OpenSource DB!
-- /v\atthew

--- postgresql-8.0.0beta1/contrib/dbsize/dbsize.c~ 2004-02-23 18:03:10.000000000 -0500
+++ postgresql-8.0.0beta1/contrib/dbsize/dbsize.c 2004-08-11 17:08:44.000000000 -0400
@@ -7,6 +7,7 @@
#include "access/heapam.h"
#include "catalog/catalog.h"
#include "catalog/namespace.h"
+#include "catalog/pg_tablespace.h"
#include "commands/dbcommands.h"
#include "fmgr.h"
#include "storage/fd.h"
@@ -55,7 +56,7 @@
(errcode(ERRCODE_UNDEFINED_DATABASE),
errmsg("database \"%s\" does not exist", NameStr(*dbname))));

- dbpath = GetDatabasePath(dbid);
+ dbpath = GetDatabasePath(dbid, GLOBALTABLESPACE_OID);

dirdesc = AllocateDir(dbpath);
if (!dirdesc)

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PostgreSQL Bugs List 2004-08-11 21:56:24 BUG #1213: version 8.0 install error in beta1 msi
Previous Message Kris Jurka 2004-08-11 20:38:00 Re: BUG #1211: JDBC connection