Skip site navigation (1) Skip section navigation (2)

Re: logfile subprocess and Fancy File Functions

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>,PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: logfile subprocess and Fancy File Functions
Date: 2004-07-24 16:01:04
Message-ID: 200407241601.i6OG14X04915@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Andreas didn't ask for a full file API.  I suggested it because we were
> > already going to have some of the functionality.  If rename/unlink are
> > new problems, we can skip them and just add what Andreas needs right
> > now.
> 
> Given the security worries that have been raised, and the fact that none
> of this functionality existed in the patch as it stood at feature-freeze
> time, I think there's more than sufficient reason to defer all the
> writing stuff to a future release cycle.

Agreed.

> I'd like to limit the functionality added now to just file-read and
> directory-list commands; and perhaps we ought to go back to limiting

Yes.

> them to work on the configured log output directory rather than being
> general purpose.  If they are general purpose, I'm going to want them to
> take only absolute paths, which will make it harder to use them for
> fetching the logs.  (Not impossible, since we could demand that the GUC
> variable holding the log directory be an absolute path, but maybe it's
> just better to stay away from the notion of a general file access API
> until we've thought harder about the security implications.)

Agreed it should be relative to the log directory, which may or not be
under PGDATA, and don't let them go up above it.  Is there any downside
to allowing absolute reads as well because COPY can already read
absolute files.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2004-07-24 16:12:52
Subject: Re: logfile subprocess and Fancy File Functions
Previous:From: Tom LaneDate: 2004-07-24 15:16:44
Subject: Re: autovauum integration patch: Attempt #4

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group