Re: make LockRelation use top transaction ID

From: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: make LockRelation use top transaction ID
Date: 2004-07-24 15:03:51
Message-ID: 20040724150351.GA4038@dcc.uchile.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 23, 2004 at 09:49:05AM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
> > I just figured that if we let LockRelation use GetCurrentTransactionId()
> > then the wrong thing happens if we let large objects survive
> > subtransaction commit/abort.
>
> > So I have changed it to use GetTopTransactionId() instead. Is that OK
> > with everybody?
>
> No, at least not if you made that a global change. Doing it that way
> will mean that a failed subtransaction will not release its locks, no?

Hmm ... won't they be released when the ResourceOwner is released?

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"Ni aun el genio muy grande llegaría muy lejos
si tuviera que sacarlo todo de su propio interior" (Goethe)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-07-24 18:53:50 Re: Nested xact status?
Previous Message Alvaro Herrera 2004-07-24 14:33:12 Re: Nested xact status?