Skip site navigation (1) Skip section navigation (2)

Re: win2k, service, pg_ctl, popen, etc

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
Cc: "'Magnus Hagander'" <mha(at)sollentuna(dot)net>,pgsql-hackers-win32(at)postgresql(dot)org
Subject: Re: win2k, service, pg_ctl, popen, etc
Date: 2004-07-22 03:28:43
Message-ID: 200407220328.i6M3Sh417004@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers-win32
Claudio Natoli wrote:
> 
> > Have you looked at find_other_exec().  We call find_my_exec(), then
> 
> Yes. IIRC, I assisted you with the recent refactoring of exec.c.
> 
> 
> > assuming that works, we go ahead and check versions.  We don't loop back
> > and keep poking around until we find a matching version.
> >
> > This code was added particularly so relocable installs don't get wacked
> > out, and you can bet Win32 will wack it out even more than unix folks.
> 
> GetMFN used in find_my_exec will continue to allow relocatable installs.
> What it does is remove any ambiguity over having found the correct location
> of the running binary. In this case, all that the version check then
> achieves (other than consistency between *nix and Win32) is to make sure
> that people don't mix different versions of PostgreSQL binaries in the same
> directory, which IMHO seems like overkill.
> 
> 
> > I am not willing to loosen that check for Win32 --- in fact I 
> > would like that check especially for Win32 where users are less
> experienced.
> 
> That is clear. I lack any concern for users who mix PostgreSQL binaries of
> different versions in the same directory, but you maintain concern. We
> simply disagree. 

We have received several bug reports of binary mismatches so tightening
it seems logical, and we are doing it in all cases:

	pg_ctl finding postmaster
	postmaster finding postgres
	initdb finding postgres
	pg_dumpall finding pg_dump

It has _nothing_ to do with any weakness in finding our own binary path
under Unix.  

It all happens in exec.c.  The test is simple in Unix.  If it isn't
simple in Win32, then we need to work harder to make it happen.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-hackers-win32 by date

Next:From: Bruce MomjianDate: 2004-07-22 03:55:11
Subject: Re: Borland c++ compile problems...
Previous:From: Claudio NatoliDate: 2004-07-22 03:15:07
Subject: Re: win2k, service, pg_ctl, popen, etc

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group