Skip site navigation (1) Skip section navigation (2)

Re: pgsql-server: Use strdup in pg_ctl for canonicalize_path

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server: Use strdup in pg_ctl for canonicalize_path
Date: 2004-07-12 19:54:30
Message-ID: 200407121954.i6CJsUn04981@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> You're not doing very well with this project :-(.  pg_ctl is now
> >> actively broken, because the PGDATA value passed down to the
> >> bootstrap backend is the one in the environment variable.  The
> >> previous coding canonicalized that, this does not.
> 
> > I didn't think we could modify the environment variables like that
> > portably.
> 
> Possibly not, but if you think that then the correct response is to
> re-assign the environment var using putenv().

Yea, but we clean up the variable on input to the backend anyway.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-committers by date

Next:From: Bruce MomjianDate: 2004-07-12 20:11:55
Subject: pgsql-server: Add Win32-specific join ordering.
Previous:From: Tom LaneDate: 2004-07-12 19:45:44
Subject: Re: pgsql-server: Use strdup in pg_ctl for canonicalize_path on environment

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group