Skip site navigation (1) Skip section navigation (2)

Re: eventlog fix

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Magnus Hagander <mha(at)sollentuna(dot)net>,Laurent Ballester <postgresql(dot)ballester(at)wanadoo(dot)fr>,pgsql-patches(at)postgresql(dot)org
Subject: Re: eventlog fix
Date: 2004-06-20 00:59:12
Message-ID: 200406200059.i5K0xCq19397@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Dave Page wrote:
>  
> 
> > -----Original Message-----
> > From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us] 
> > Sent: 19 June 2004 22:49
> > To: Dave Page
> > Cc: Magnus Hagander; Bruce Momjian; Laurent Ballester; 
> > pgsql-patches(at)postgresql(dot)org
> > Subject: Re: [PATCHES] eventlog fix 
> > 
> > Hm, that is a lot ... but wouldn't the sort of people 
> > interested in hacking PG on Windows likely already have it?
> > 
> > If you think not, I'll withdraw my objection to keeping the 
> > .BIN in CVS, but I'm just wondering whether we're worrying 
> > about something that hackers would have anyway.
> 
> I have mc.exe, but only because I have paid for Visual Studio. I don't
> have the platform SDK installed, however I cannot honestly say whether
> or not I would have it if I didn't have VS. I would include the file in
> CVS if it were my choice - it's clearly a pain to download the compiler
> if you don't have it, and the file is unlikely to need updating in the
> future - it was designed to be a generic DLL that just formats any
> message as '%s'.

Agreed.  We have to include the .bin file because if we don't, we would
have an additional Win32 depenency beyond Mingw.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2004-06-20 01:13:18
Subject: Re: Compiling libpq with VisualC
Previous:From: Bruce MomjianDate: 2004-06-20 00:55:57
Subject: Re: Tablespace patch review

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group