Skip site navigation (1) Skip section navigation (2)

Re: Re : Win32 binaries test / pg_dump problem

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers-win32(at)postgresql(dot)org
Subject: Re: Re : Win32 binaries test / pg_dump problem
Date: 2004-06-10 02:42:43
Message-ID: 200406100242.i5A2ghq27892@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers-win32pgsql-patches
Would someone verify that having psql open the file in binary mode fixes
the problem?

---------------------------------------------------------------------------

Andrew Dunstan wrote:
> Bruce Momjian wrote:
> 
> >Andrew Dunstan wrote:
> >  
> >
> >>Cyril VELTER said:
> >>    
> >>
> >>>From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
> >>>
> >>>      
> >>>
> >>>>Cyril VELTER wrote:
> >>>>
> >>>>        
> >>>>
> >>>>>    if you psql -f test.sql basetest from the windows shell to a
> >>>>>    windows
> >>>>>          
> >>>>>
> >>>or
> >>>      
> >>>
> >>>>>linux database, you'll get a missing data error :
> >>>>>
> >>>>>psql:test.sql:9: ERROR:  missing data for column "b"
> >>>>>CONTEXT:  COPY test, line 1: "a"
> >>>>>
> >>>>>    if you psql -f test.sql basetest from a linux shell to a windows
> >>>>>    or
> >>>>>linux database, you won't get an error
> >>>>>          
> >>>>>
> >>>>Sounds like we should have psql open the file in binary mode on
> >>>>Windows. Would that cause problems? I doubt it, but I wonder.
> >>>>
> >>>>        
> >>>>
> >>>   you might be right, I just found some information on msdn that fseek
> >>>   for
> >>>example is influenced by ctrl-z when the file is opened in text mode.
> >>>
> >>>   I'm not sure that this is the cause of the second problem (backend
> >>>   crash
> >>>on copy to) though.
> >>>
> >>>   do you known where this modification needs to be done ?
> >>>
> >>>   cyril
> >>>
> >>>      
> >>>
> >>probably in src/bin/psql/command.c::process_file()
> >>
> >>instead of mode "r" we should probably use the predefined constant
> >>PG_BINARY_R
> >>    
> >>
> >
> >Uh, but it isn't a binary file, it is SQL commands.
> >
> >  
> >
> 
> If it can have an embedded ^Z it is not a legal Windows text file.
> 
> Adding the binary flag will have exactly 2 effects:
> 1. It will inhibit the behaviour of the driver in translating CRLF to 
> plain LF
> 2. It will not see ^Z as EOF.
> 
> We don't care about the first - we handle CRLF just fine. But we do care 
> about the second, and we don't want the library to interpret ^Z as EOF.
> 
> cheers
> 
> andrew
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
>       subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
>       message can get through to the mailing list cleanly
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2004-06-10 02:49:06
Subject: Re: [HACKERS] dynamic_library_path on Win32
Previous:From: Bruce MomjianDate: 2004-06-10 02:39:32
Subject: Re: pg_dump and schema namespace notes

pgsql-hackers-win32 by date

Next:From: Bruce MomjianDate: 2004-06-10 04:01:25
Subject: Re: [HACKERS] select like...not using index
Previous:From: Gary DoadesDate: 2004-06-09 20:13:12
Subject: Re: pg_ctl start broken on windows

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group