Skip site navigation (1) Skip section navigation (2)

Re: pg_ctl-related "fixes"

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Serguei A(dot) Mokhov" <mokhov(at)cs(dot)concordia(dot)ca>
Cc: momjian(at)svr1(dot)postgresql(dot)org, pgsql-committers(at)postgresql(dot)org
Subject: Re: pg_ctl-related "fixes"
Date: 2004-06-01 22:05:26
Message-ID: 200406012205.i51M5Qi04306@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Serguei A. Mokhov wrote:
> On Tue, 1 Jun 2004, Bruce Momjian wrote:
> 
> > Date: Tue, 1 Jun 2004 16:19:05 -0400 (EDT)
> >
> > > > The first commit just did the init_nls changes while the second was all
> > > > pg_ctl.  Sorry.
> > >
> > > But the locale and NLS issues for pg_ctl still remain unfixed.
> >
> > The only thing I have not done is to add the Russian part.  pg_ctl.c
> > should have everthing it needs, right?
> 
> It's missing these entirely:
> 
> ***************
> *** 798,803 ****
> --- 799,810 ----
>   int
>   main(int argc, char **argv)
>   {
> + #ifdef ENABLE_NLS
> + 	setlocale(LC_ALL, "");
> + 	bindtextdomain(progname, LOCALEDIR);
> + 	textdomain(progname);
> + #endif
> +
>   	static struct option long_options[] = {
>   		{"help", no_argument, NULL, '?'},
>   		{"version", no_argument, NULL, 'V'},

Oops, I thought I added set_pglocale(argv[0], "pg_ctl") to pg_ctl.c, but
I think I just removed init_nls without touching pg_ctl.  Fixed now.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-committers by date

Next:From: Tom LaneDate: 2004-06-02 17:28:19
Subject: pgsql-server: Adjust btree index build to not use shared buffers,
Previous:From: Bruce MomjianDate: 2004-06-01 22:03:19
Subject: pgsql-server: Add locale setting for pg_ctl.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group