Re: Converting postgresql.conf parameters to kilobytes

On Monday 31 May 2004 18:41, Bruce Momjian wrote:
> Shridhar Daithankar wrote:
> > On Sunday 30 May 2004 21:33, Tom Lane wrote:
> > > Shridhar Daithankar <shridhar(at)frodo(dot)hserus(dot)net> writes:
> > > > I was toying around with idea of converting all the memory related
> > > > parameters in postgresql.conf to kilobytes for simplicity and
> > > > uniformity.
> > >
> > > Why is that a good idea?
> >
> > Right now following are measured in pages
> > wal_buffers
> > shared_buffers
> > effective_cachesize
> >
> > Following are in kbs
> > work_mem
> > maintenance_work_mem
> > max_stack_depth
> >
> > while rest of the memory parameters are in kb. I thought being uniform
> > would be good. Besides it will make it independent of page size as well.
>
> Sounds good to me. How are you handling cases where the value has to be
> a multiple of page size --- rounding or throwing an error?

The patch rounds it down owing to assignment of possible real number to
integer. but I didn't imagine of this requirement, to be honest.

This seems to be better behavior than throwing an error.

Shridhar