Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] pg_autovacuum fixes

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Matthew T(dot) O'Connor" <matthew(at)zeut(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org,PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] pg_autovacuum fixes
Date: 2004-05-24 03:07:59
Message-ID: 200405240307.i4O37xs19056@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Matthew T. O'Connor wrote:
> This weekend I am trying to fix up all known the pg_autovacuum issues
> that should be resolved for 7.4.3.  I am aware of only two issues:  temp
> table issues, and unchecked send_query() calls, if I am forgetting
> something, please let me know.
> 
> 1) temp table issue:  
> I was not able to reproduce the crash associated with temp tables.  I
> spent a while creating tables doing updates and dropping them trying
> without success to get pg_autovacuum to crash.  Since I couldn't trigger
> the problem, I will need someone else to test to see if I have fixed the
> problem.  Anyway, I have modified the query to exclude temp tables from
> the list of tables to work with.  So we should no longer be dealing with
> temp tables at all which should side step any temp table related problem
> we might have been having.
> 
> 2) Unchecked send_query() function calls:
> As best as I can tell, this is mostly a non-issue, but I went ahead
> added a check to any section that did anything with the result of
> send_query, so if this was an issue, it should be fixed now.  BTW, this
> might have been the cause of the temp table related crash, but that is
> just a guess.

It is not a non-issue.  A query could fail for thousands of reasons, and
doing a core dump is never a solution.

Yes, these are the only two known issues.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2004-05-24 03:22:53
Subject: Re: Latest requests from IRC
Previous:From: Bruce MomjianDate: 2004-05-24 03:05:28
Subject: Re: pg_autovacuum fixes

pgsql-patches by date

Next:From: Neil ConwayDate: 2004-05-24 03:28:57
Subject: Re: WIP list rewrite
Previous:From: Bruce MomjianDate: 2004-05-24 03:05:28
Subject: Re: pg_autovacuum fixes

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group