Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p
Date: 2004-05-19 19:02:10
Message-ID: 200405191902.i4JJ2AO16379@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> And tested?  I didn't say that I thought elog would work in main.c.
> >> In fact I'm pretty certain it won't.
> 
> > Compiles/regression tests pass.  
> 
> You need to test the cases that will produce elog output.
> 
> > This is why I removed elog in the first place, because I thought it
> > wouldn't work up higher before the guc load, but you said it would use
> > the default.  Are you saying it only works after guc is loaded?
> 
> No, I specifically said it didn't need guc.  But it does need palloc,
> which means MemoryContextInit() has to run first.  I could see running
> find_my_exec immediately before InitializeGUCOptions() in PostmasterMain.

OK, I moved the find_my_exec calls to the locations you mentioned in
both postgres.c and postmaster.c and remove it from main.c.  I tested
the elog and it worked.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-committers by date

Next:From: Bruce MomjianDate: 2004-05-19 19:11:26
Subject: pgsql-server/src/backend/postmaster postmaster.c
Previous:From: Bruce MomjianDate: 2004-05-19 18:58:45
Subject: pgsql-server/src/backend main/main.c postmaste ...

pgsql-patches by date

Next:From: Tom LaneDate: 2004-05-19 19:11:33
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p
Previous:From: Tom LaneDate: 2004-05-19 18:21:11
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p ...

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group