Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> And tested? I didn't say that I thought elog would work in main.c.
> >> In fact I'm pretty certain it won't.
> > Compiles/regression tests pass.
> You need to test the cases that will produce elog output.
> > This is why I removed elog in the first place, because I thought it
> > wouldn't work up higher before the guc load, but you said it would use
> > the default. Are you saying it only works after guc is loaded?
> No, I specifically said it didn't need guc. But it does need palloc,
> which means MemoryContextInit() has to run first. I could see running
> find_my_exec immediately before InitializeGUCOptions() in PostmasterMain.
OK, I moved the find_my_exec calls to the locations you mentioned in
both postgres.c and postmaster.c and remove it from main.c. I tested
the elog and it worked.
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
In response to
pgsql-committers by date
|Next:||From: Bruce Momjian||Date: 2004-05-19 19:11:26|
|Subject: pgsql-server/src/backend/postmaster postmaster.c|
|Previous:||From: Bruce Momjian||Date: 2004-05-19 18:58:45|
|Subject: pgsql-server/src/backend main/main.c postmaste ...|
pgsql-patches by date
|Next:||From: Tom Lane||Date: 2004-05-19 19:11:33|
|Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p |
|Previous:||From: Tom Lane||Date: 2004-05-19 18:21:11|
|Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p ... |