Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p ...

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p ...
Date: 2004-05-19 17:37:45
Message-ID: 200405191737.i4JHbjW17192@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > so it has to be earlier.  I can put it much earlier in both postgres and
> > postmaster, but by having it in main.c, I have it in only one place.  It
> > doesn't do any palloc or anything fancy, because of course it is also
> > used by client apps.
> 
> > Patch attached and applied.
> 
> And tested?  I didn't say that I thought elog would work in main.c.
> In fact I'm pretty certain it won't.

Compiles/regression tests pass.  

This is why I removed elog in the first place, because I thought it
wouldn't work up higher before the guc load, but you said it would use
the default.  Are you saying it only works after guc is loaded?  Seems
we have a chicken and egg thing here.  I think the guc load needs the
default timezone, and for that we need the exec path so we can find
share.

So, what do you want with the code?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-committers by date

Next:From: Tom LaneDate: 2004-05-19 18:21:11
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p ...
Previous:From: Tom LaneDate: 2004-05-19 17:27:33
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p ...

pgsql-patches by date

Next:From: Jorge PereiraDate: 2004-05-19 18:01:00
Subject: Disabling triggers / constraints
Previous:From: Tom LaneDate: 2004-05-19 17:27:33
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p ...

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group