Re: ALTER TABLE TODO items

From: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
To: "scott(dot)marlowe" <scott(dot)marlowe(at)ihs(dot)com>, Richard Huxton <dev(at)archonet(dot)com>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ALTER TABLE TODO items
Date: 2004-05-06 19:02:02
Message-ID: 200405061502.02594.xzilla@users.sourceforge.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thursday 06 May 2004 11:47, scott.marlowe wrote:
> On Thu, 6 May 2004, Richard Huxton wrote:
> > Bruce Momjian wrote:
> > > Tom Lane wrote:
> > >>Richard Huxton <dev(at)archonet(dot)com> writes:
> > >>>Does that mean I'll want to disable triggers while I do this?
> > >>
> > >>Hrm. Right now the code does not fire triggers at all, but that seems
> > >>wrong. However, I doubt that very many triggers could cope with update
> > >>events in which the old and new rows have different rowtypes :-(.
> > >>Any thoughts what to do about that?
> > >
> > > If triggers exist, I think we should just throw a warning that triggers
> > > will not be fired.
> >
> > Tom's point about triggers probably not working after the upgrade is a
> > good one though. Is it reasonable to just refuse to act on a table until
> > all triggers are dropped? I'd rather be forced to go through and
> > drop/restore triggers in a script than be surprised later on.
>
> How about "cascade drop triggers" as an option so you can still do it in
> one line should you want to?

What about rules/views/functions and who knows what else (domains?) might be
dependant on the current type definition? It seems like a pretty big can of
worms really.

Robert Treat
--
Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2004-05-06 19:04:32 Re: ALTER TABLE TODO items
Previous Message Bruce Momjian 2004-05-06 16:59:16 pgsql-server/ oc/src/sgml/ref/alter_user.sgml ...

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-05-06 19:02:06 Re: alter table alter columns vs. domains
Previous Message Rod Taylor 2004-05-06 19:00:12 Re: alter table alter columns vs. domains