Skip site navigation (1) Skip section navigation (2)

Re: pgsql-server/src/timezone pgtz.h

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server/src/timezone pgtz.h
Date: 2004-05-01 01:36:11
Message-ID: 200405010136.i411aBm02941@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Tom Lane wrote:
> momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian) writes:
> > 	Timezone code checks for HAVE_SYMLINK of zero, so use in pgtz.h:
> 	
> > 	#ifndef HAVE_SYMLINK
> > 	#define HAVE_SYMLINK 0
> > 	#endif
> 
> Surely this is exactly the wrong thing to do.  It will break code that
> tests for #ifdef HAVE_SYMLINK.  Shouldn't you instead fix the timezone
> library to make its tests in a more standard way?

I thought about that but I figured the less we change the tz library,
the easier it will be to replace later.  The code uses a zero test
rather than an undef test, and that seemed OK to me assuming we will not
be mucking with this code at all.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-committers by date

Next:From: Bruce MomjianDate: 2004-05-01 01:38:53
Subject: pgsql-server/src/timezone pgtz.c
Previous:From: Tom LaneDate: 2004-05-01 01:34:48
Subject: Re: pgsql-server/src/timezone pgtz.h

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group