Skip site navigation (1) Skip section navigation (2)

Re: FW: Timezone library

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Magnus Hagander <mha(at)sollentuna(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: FW: Timezone library
Date: 2004-04-27 03:06:21
Message-ID: 200404270306.i3R36L722474@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
I assume we want to integrate our own timezone library into PostgreSQL. 
We have talked about it for a few releases, and Magnus has done it for
us because Win32 needs it for pre-1970 dates.

The patch to PostgreSQL is 100 lines of diff, and the changes to Olson's
timezone library is 100 lines of diff.   The timezone library itself is
173k tgz file, which will add to our download size, but not too much.

Your patch has been added to the PostgreSQL unapplied patches list at:

	http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------


Magnus Hagander wrote:
> This mail apparantly didn't make it through because it was too large.
> Resending it without the largest file, tzlib.tgz. I've put this file (+
> the patches) on http://www.hagander.net/pgsql/.
> 
> 
> //Magnus
> 
> 
> > -----Original Message-----
> > From: Magnus Hagander 
> > Sent: Sunday, April 18, 2004 9:05 PM
> > To: pgsql-patches(at)postgresql(dot)org
> > Subject: Timezone library
> > 
> > 
> > Hi!
> > 
> > Attached is a slightly modified version of Arthur David 
> > Olson's timezone library for inclusion in postgresql, pending 
> > review of course. This is required to give win32 working 
> > timezone functions on dates before 1970. It has also been 
> > indicated that it might be interesting to have such a library 
> > on other platforms as well. Note that with this enabled, the 
> > timezone data files are installed in <pgdir>/share/timezone.
> > 
> > Attached are the following files:
> > * tzlib.tgz - the timezone implementation, including the 
> > datafiles required to build the timezone data files.
> > * timezone.patch - the modifications made to existing files 
> > to make it work. This includes setting the FRONTEND flat for ecpg.
> > * tzcode.diff - lists the modifications that I have made to 
> > the files from the original timezone files, for reference. 
> > 
> > 
> > Bruce has offered to do the autoconf and Makefile integration 
> > parts - I don't know autoconf enough to do that part... The 
> > #defines necessary are "activeted" by setting USE_PGTZ. Of 
> > course, the appropriate files also have to be linked in.
> > 
> > 
> > With this patch applied, and the timezone data installed, 
> > win32 now passes all time-related regression tests (3 now 
> > fails, 2 "known" and one being locale-inflicted, still 
> > investigating that one)
> > 
> > 
> > //Magnus
> >    
> > 
> > 
> > 
>  <<tzcode_changes.diff>>  <<timezone.patch>> 

Content-Description: tzcode_changes.diff

[ Attachment, skipping... ]

Content-Description: timezone.patch

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2004-04-27 03:34:17
Subject: Re: Reporting a security hole
Previous:From: Alvaro HerreraDate: 2004-04-27 02:04:13
Subject: Re: Broken Catalog? -- 7.4.2

pgsql-patches by date

Next:From: Bruce MomjianDate: 2004-04-27 03:30:16
Subject: Re: Basic subtransaction facility
Previous:From: Bruce MomjianDate: 2004-04-27 02:16:19
Subject: Re: [BUGS] BUG #1134: ALTER USER ... RENAME breaks md5 passwords

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group