Skip site navigation (1) Skip section navigation (2)

Re: Plan for CSV handling of quotes, NULL

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>,Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Plan for CSV handling of quotes, NULL
Date: 2004-04-15 04:03:46
Message-ID: 200404150403.i3F43ko07299@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Bruce Momjian wrote:
> Bruce Momjian wrote:
> > I talked to Andrew on IRC and we went over the open CSV issues.
> > 
> > We talked about how we could do quoting for zipcode in TEXT fields and
> > not quote true numeric values without hardcoding datatypes into the
> > system.  The most tricky case was NUMERIC vs. TEXT with zipcodes. 
> > NUMERIC and TEXT have almost identical pg_type entries, so there is
> > nothing there to help us.
> > 
> > I found parse_coerce.c::TypeCategory(), which contains information about
> > which data type oids are in which grouping, e.g. DATETIME, STRING,
> > NUMERIC, etc.  It seems that function, if called with
> > pg_type.typbasetype could help determine if quotes should be used.  My
> > idea is to skip quotes for NUMERIC and DATETIME types, and quote
> > everything else.  This means that user-defined types will always be
> > output with quotes, which is probably OK.
> > 
> > So, for open CSV items we have:
> > 
> > 	o  add oid dump/reload
> > 	o  handle loading of comma-comma into NOT NULL collumns
> > 	o  handle quoting of TEXT type with zipcodes, etc.
> 
> Oh, one more item.  CSV needs a way to output date values in Datestyle
> format, for use by spreadsheets that understand mm/dd/yy dates, but not
> ISO dates.  This will not be on by default.

Ah, I see COPY already honors DateStyle on output.  I will mention that
in the COPY docs as a tip for CSV.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-patches by date

Next:From: Tom LaneDate: 2004-04-15 04:47:14
Subject: Re: Plan for CSV handling of quotes, NULL
Previous:From: Bruce MomjianDate: 2004-04-15 02:27:52
Subject: Re: Plan for CSV handling of quotes, NULL

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group