Skip site navigation (1) Skip section navigation (2)

Re: Dates BC.

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
Cc: Dann Corbit <DCorbit(at)connx(dot)com>, Kurt Roeckx <Q(at)ping(dot)be>,pgsql-hackers(at)postgresql(dot)org
Subject: Re: Dates BC.
Date: 2004-03-30 16:20:09
Message-ID: 200403301620.i2UGK9X07305@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
I have applied a patch to fix the issues mentioned below.  Thanks.

---------------------------------------------------------------------------

Karel Zak wrote:
> On Fri, Dec 19, 2003 at 01:12:08AM -0800, Dann Corbit wrote:
> > There is no zero calendar year.  The first year of Anno Domini is 1.  It's ordinal, not cardinal.
> 
>  I agree. But  the follow quoted  code is  not use in  date_part() there
>  Kurt  found bug. It's  used  in to_timestamp()  _only_,  and it  works,
>  because tm2timestamp() and date2j() work with zero year.
> 
> > >  Is there connection between formatting.c and date_part() ? 
> > >  I don't think so...
> > > 
> > > > In backend/utils/adt/formatting.c:
> > > > 
> > > >         if (tmfc.bc)
> > > >         {
> > > >                 if (tm->tm_year > 0)
> > > >                         tm->tm_year = -(tm->tm_year - 1);
>                             
> 
>  ... "tm->tm_year = -(tm->tm_year - 1)" is used for:
> 
> # select to_timestamp('0001/01/01 BC', 'YYYY/MM/DD AD');
>      to_timestamp      
> ------------------------
>  0001-01-01 00:00:00 BC
>        
>  and it's OK.
> 
> 
>  I  think a  bug  is  somewhere in  timestamp2tm()  which  used in  next
>  examples and it's shared between more functions:
> 
> # select to_char('0001-01-01 BC'::date, 'YYYY/MM/DD AD');
>     to_char    
>  ---------------
>  0000/01/01 AD
> 
> # SELECT EXTRACT(YEAR from '0001-01-01 BC'::date);
>  date_part 
>  -----------
>          0
>            
> 
>     Karel
> 
>  
> 
> -- 
>  Karel Zak  <zakkr(at)zf(dot)jcu(dot)cz>
>  http://home.zf.jcu.cz/~zakkr/
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
>       subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
>       message can get through to the mailing list cleanly
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2004-03-30 16:22:12
Subject: Re: feature request: \qf datatype
Previous:From: Teodor SigaevDate: 2004-03-30 15:46:28
Subject: Re: GIST code doesn't build on strict 64-bit machines

pgsql-patches by date

Next:From: David TuroverDate: 2004-03-30 19:29:14
Subject: Building PgSQL 7.4.2 on SGI Irix 6.19
Previous:From: Tom LaneDate: 2004-03-30 14:26:13
Subject: Re: pg_dump end comment

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group