Skip site navigation (1) Skip section navigation (2)

Re: pg_dump end comment

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>,Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump end comment
Date: 2004-03-30 14:13:10
Message-ID: 200403301413.i2UEDAB03493@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Gavin Sherry wrote:
> On Tue, 30 Mar 2004, Bruce Momjian wrote:
> 
> > Tom Lane wrote:
> > > Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> writes:
> > > > This might seem a bit silly, but is there any chance we could add a
> > > > comment at the end of pg_dump text output that says '-- End of dump'?
> > >
> > > Sure --- while you're at it, put a "beginning of dump" at the start.
> > >
> > > Is it worth adding the database name and/or other command-line
> > > parameters given to pg_dump?
> > >
> > > One thing to think about is the difference between a bare pg_dump and a
> > > pg_dump/pg_restore sequence.  Should these always generate identical
> > > text output?  (They do as of CVS tip, I believe, though this was not
> > > always true before.)
> > >
> > > Possibly this is all gilding the lily though...
> >
> > I like an end-of-dump marker for folks who want to check if the dump got
> > truncated somehow.  I can see how to do that for text dumps, but what
> > about for tar or custom dumps?
> 
> Wouldn't it be more effective to test for non zero return status as this
> handles -Fc cases, etc, which would be non-trivial to test.

Yes, they have to check for a proper exit from pg_dump, but there is
still a file sitting around after the dump, with no way to tell if it is
accurate.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2004-03-30 14:26:13
Subject: Re: pg_dump end comment
Previous:From: Andreas PflugDate: 2004-03-30 13:24:57
Subject: Re: pg_advisor schema proof of concept

pgsql-patches by date

Next:From: Tom LaneDate: 2004-03-30 14:26:13
Subject: Re: pg_dump end comment
Previous:From: Gavin SherryDate: 2004-03-30 08:20:08
Subject: Re: pg_dump end comment

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group