Skip site navigation (1) Skip section navigation (2)

Re: default psql to localhost on platforms without unix domain

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: default psql to localhost on platforms without unix domain
Date: 2004-03-24 03:27:19
Message-ID: 200403240327.i2O3RJk19925@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-hackers-win32pgsql-patches
Should we have used 127.0.0.1 rather than 'localhost' here?

---------------------------------------------------------------------------

Andrew Dunstan wrote:
> 
> 
> Bruce Momjian wrote:
> 
> >Andrew Dunstan wrote:
> >
> >>Also, what is the default connection mode of psql? It should probably be 
> >>equivalent to "-h localhost", shouldn't it?
> >>    
> >>
> >
> >Now that is something I had not thought of.  Seems we can assume a Win32
> >psql can never use unix domain sockets, so defaulting that to localhost
> >is a good solution too.
> >
> 
> The trivial patch below does this (I think). I still don't have an 
> available Windows box for testing, so someone who does please verify.
> 
> thanks
> 
> andrew
> 
> Index: src/bin/psql/startup.c
> ===================================================================
> RCS file: /projects/cvsroot/pgsql-server/src/bin/psql/startup.c,v
> retrieving revision 1.85
> diff -c -r1.85 startup.c
> *** src/bin/psql/startup.c 19 Feb 2004 19:40:09 -0000 1.85
> --- src/bin/psql/startup.c 15 Mar 2004 10:37:50 -0000
> ***************
> *** 153,158 ****
> --- 153,162 ----
> pset.getPassword = false;
> #endif
> 
> + #ifndef HAVE_UNIX_SOCKETS
> + options.host = "localhost";
> + #endif
> +
> parse_psql_options(argc, argv, &options);
> 
> if (!pset.popt.topt.fieldSep)
> 
> 
> 
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2004-03-24 03:27:57
Subject: Re: dollar quoting and pg_dump
Previous:From: Bruce MomjianDate: 2004-03-24 03:10:46
Subject: Re: default psql to localhost on platforms without unix domain

pgsql-patches by date

Next:From: Tom LaneDate: 2004-03-24 03:27:57
Subject: Re: dollar quoting and pg_dump
Previous:From: Bruce MomjianDate: 2004-03-24 03:10:46
Subject: Re: default psql to localhost on platforms without unix domain

pgsql-hackers-win32 by date

Next:From: Tom LaneDate: 2004-03-24 03:42:19
Subject: Re: default psql to localhost on platforms without unix domain
Previous:From: Bruce MomjianDate: 2004-03-24 03:10:46
Subject: Re: default psql to localhost on platforms without unix domain

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group