Fix for fseeko.c and pg_dump -Ft

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Fix for fseeko.c and pg_dump -Ft
Date: 2004-03-23 05:30:11
Message-ID: 200403230530.i2N5UBY21732@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

I just fixed a problem with our port/fseeko.c code.

I added an fflush() so the FILE buffer would update the file descriptor
so stat() gets proper size in fseeko.c.

This fixes a problem with pg_dump tar backups. Only happens on
platforms that use our port/fseeko.c, which is currently BSD/OS and
NetBSD. The error would be:

$ pg_dump -Ft test >/dev/null
pg_dump: [tar archiver] actual file length (2171) does not match
expected (2171)

Backpatched to 7.4.X too.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 548 bytes

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2004-03-23 06:10:01 Re: charset / postmaster doc improv
Previous Message Tom Lane 2004-03-23 04:54:55 Re: charset / postmaster doc improv