| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com> |
| Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Removal of win32-specific rename code |
| Date: | 2004-03-16 13:23:12 |
| Message-ID: | 200403161323.i2GDNCB05699@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Claudio Natoli wrote:
>
> > main file. WIth Claudio's fix, this isn't necessary.
>
> Bruce, are you sure this is true? The fix is only for files than are
> open()'d, not fopen()'d (as per AllocateFile).
If your fix works, I will change the Win32-specific code to use open()
and fdopen(). The only advantage to the old code was that it would
release locks, then go into a rename loop, which is horid, and we need
to avoid the loop.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | D.J. Heap | 2004-03-16 14:37:05 | Re: win32 open patch for held unlink |
| Previous Message | Claudio Natoli | 2004-03-16 06:11:25 | Re: Removal of win32-specific rename code |