Skip site navigation (1) Skip section navigation (2)

Re: win32 open patch for held unlink

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
Cc: "'pgsql-patches(at)postgresql(dot)org'" <pgsql-patches(at)postgresql(dot)org>,pgsql-hackers-win32(at)postgresql(dot)org
Subject: Re: win32 open patch for held unlink
Date: 2004-03-16 03:33:20
Message-ID: 200403160333.i2G3XK106067@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers-win32pgsql-patches
Claudio Natoli wrote:
> 
>  
> > Claudio, how does this handle renames if the file is open by someone
> > else?  Does this remove the need to loop over the rename?
> 
> To be honest, I don't know that it does. [Will report back later.]
> 
> Two points though:
> 
> a) This could doesn't alleviate the needs for dirmod.c, as far as I'm aware.
> That seems to be there for a different reason, namely that there appears to
> be some timing issue between creating a file and issuing an unlink/rename.
> 
> b) Do we have a case where rename's can block because of the file being held
> open by another process? I haven't tripped over this yet...

Agreed, we still need dirmod.c in case someone has opened it using a
non-unix mode.  My only question was whether this new mode makes rename
possible on a target file opened by another backend.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-patches by date

Next:From: Claudio NatoliDate: 2004-03-16 04:22:39
Subject: Re: win32 open patch for held unlink
Previous:From: Claudio NatoliDate: 2004-03-16 03:22:55
Subject: Re: win32 open patch for held unlink

pgsql-hackers-win32 by date

Next:From: Claudio NatoliDate: 2004-03-16 04:22:39
Subject: Re: win32 open patch for held unlink
Previous:From: Claudio NatoliDate: 2004-03-16 03:22:55
Subject: Re: win32 open patch for held unlink

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group