From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: log_line_info |
Date: | 2004-03-09 04:46:05 |
Message-ID: | 200403090446.i294k5G28367@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Oh, I also renamed it to "log_line_prefix", which was one of your
suggestions. And I also updated some of the documentation phrasing.
I also marked the TODO item as completed.
Thanks.
---------------------------------------------------------------------------
Andrew Dunstan wrote:
>
> I think this is now ready for application, unless someone objects.
>
> Since the last patch I posted, I have done the following:
>
> . changed the escapes to lower case, as Peter prefers. This is also in
> line with what Apache does, which is the nearest equivalent I can think of.
> . added 2 new escapes: %r = remote host and port and %x says "postmaster
> and friends stop here". Postmaster and friends will also ignore any
> escapes they see that don't make sense (specifically %u %d %i %r %s and
> %c). However, they no longer ignore the whole facility. This means we
> can use it for logging (for example) timestamps and pids in all cases.
> . added docco
> . changed source port reporting from host:port to host(port) to avoid
> IP6 address ambiguity.
>
> If someone wants to monkey with the name of the facility, it shouldn't
> be hard. I don't like plain "log_line", though. "log_line_prefix" or
> "log_line_tag" both seem to me better alternatives.
>
> After this is applied (fingers crossed) and everyone is happy, I will
> submit a patch to remove log_timestamp, log_pid and (if we are agreed on
> it) log_source_port.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Tatsuo Ishii | 2004-03-09 05:10:58 | Re: [PATCHES] NO WAIT ... |
Previous Message | Bruce Momjian | 2004-03-09 04:40:39 | Re: log_line_info |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-03-09 04:49:03 | Re: canonicalize_path: initdb.c -> port/path.c |
Previous Message | Bruce Momjian | 2004-03-09 04:40:39 | Re: log_line_info |