Re: pgsql-server/contrib/xml Makefile README.pgxml ...

Christopher Kings-Lynne wrote:
> Shouldn't we make this a totally new 'xml2' contrib, like we did for
> tsearch2?
>
> Especially since it is backwards incompatible and has a huge security
> hole? (url fetching)

Done. I kept the old version in /xml, and put the new version in xml2.
I updated the contrib README. Not sure why I didn't think of this
myself.

---------------------------------------------------------------------------

>
> Chris
>
>
> Bruce Momjian wrote:
>
> > CVSROOT: /cvsroot
> > Module name: pgsql-server
> > Changes by: momjian(at)svr1(dot)postgresql(dot)org 04/03/04 23:24:50
> >
> > Modified files:
> > contrib/xml : Makefile README.pgxml pgxml.sql.in
> > Added files:
> > contrib/xml : xpath.c xslt_proc.c
> > Removed files:
> > contrib/xml : TODO pgxml.c pgxml.h pgxml_dom.c
> > pgxml_dom.sql.in
> >
> > Log message:
> > Thanks to the generous support of Torchbox (http://www.torchbox.com), I
> > have been able to significantly improve the contrib/xml XPath
> > integration code.
> >
> > New features:
> >
> > * XPath set-returning function allows multiple results from an several
> > XPath queries to be used as a virtual table.
> > * Using libxslt, XSLT transformations (with and without parameters) are
> > supported. (Caution: This support allows generic URL fetching from
> > within the backend as well).
> >
> > I've removed the old code so that it is all libxml based. Rather than
> > attach as a patch, I've put the tar.gz (10k!) at
> > http://www.azuli.co.uk/pgxml-1.0.tar.gz
> > (all files in archive are xml/....).
> >
> > I think this is worth replacing the contrib version with, even though
> > the function names have changed (though the same functionality is
> > there), because it includes a SRF and some SPI usage, in addition to
> > linking to an external library. And it isn't a big module! Obviously, I
> > understand that people might prefer to move it elsewhere, or might have
> > reservations about replacing an existing contrib module with an
> > incompatible one. I'm open to suggestions.
> >
> > John Gray
> >
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 2: you can get off all lists at once with the unregister command
> > (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073