From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: [PATCHES] log_line_info |
Date: | 2004-02-29 04:31:53 |
Message-ID: | 200402290431.i1T4Vrs27431@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Andrew Dunstan wrote:
> >Nice. Only two comments --- does this mean we should remove log_pid?
> >Seems it is now duplicate functionality. Is that the only duplication?
> >Also, I don't see any documention changes in the patch, but I assume you
> >will work on that before final.
> >
>
> I will do docs. We could sensibly get rid of log_pid and log_timestamp
> with my latest patch. I would also suggest getting rid of
> log_source_port, since there really isn't any reason *not* to log the
> source port. Do you want me to make those changes in my patch? Or I can
> leave them for now and we can get rid of them when everyone is happy.
I agree, but let's make it a separate patch.
Oh, I think we still need log_timestamp for postmaster-generated lines,
no? What does log_line_info output for postmaster-generated logs?
Also, should we call the option just log_line? Is that clearer, or
log_line_prefix?
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2004-02-29 04:44:31 | Re: [PATCHES] log_line_info |
Previous Message | Andrew Dunstan | 2004-02-29 03:22:49 | Re: log_line_info |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2004-02-29 04:44:31 | Re: [PATCHES] log_line_info |
Previous Message | Claudio Natoli | 2004-02-29 03:25:53 | win32 regress makefile |