Re: [PATCHES] fork/exec patch: pre-CreateProcess finalization

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jan Wieck <JanWieck(at)Yahoo(dot)com>, Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>, "''pgsql-patches(at)postgresql(dot)org' '" <pgsql-patches(at)postgresql(dot)org>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: [PATCHES] fork/exec patch: pre-CreateProcess finalization
Date: 2004-01-09 23:11:28
Message-ID: 200401092311.i09NBSG23047@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches

Tom Lane wrote:
> Jan Wieck <JanWieck(at)Yahoo(dot)com> writes:
> > Something after 2003/11/20 enhanced the query cancel handling. Namely,
> > CVS tip now responds to a query cancel with a postmaster restart
> > canceling all queries. Could the fork/exec stuff be responsible for this?
>
> Whoever changed this:
>
> status = ProcessStartupPacket(port, false);
>
> if (status != STATUS_OK)
> return 0; /* cancel request processed, or error */
>
> to this:
>
> status = ProcessStartupPacket(port, false);
>
> if (status != STATUS_OK)
> {
> ereport(LOG,
> (errmsg("connection startup failed")));
> proc_exit(status);
> }
>
> is responsible. May we have an explanation of the thought process,
> if any?

Claudio specified the attached fix, which I have applied (this time).

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 636 bytes

In response to

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Tom Lane 2004-01-09 23:22:18 Re: [PATCHES] fork/exec patch: pre-CreateProcess finalization
Previous Message Bruce Momjian 2004-01-09 23:10:53 Re: [PATCHES] fork/exec patch: pre-CreateProcess finalization

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-01-09 23:22:18 Re: [PATCHES] fork/exec patch: pre-CreateProcess finalization
Previous Message Bruce Momjian 2004-01-09 23:10:53 Re: [PATCHES] fork/exec patch: pre-CreateProcess finalization