Re: [HACKERS] [PATCHES] fork/exec patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <mha(at)sollentuna(dot)net>, pgsql-hackers-win32 <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCHES] fork/exec patch
Date: 2003-12-17 15:30:11
Message-ID: 200312171530.hBHFUBh05241@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32

Tom Lane wrote:
> "Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> > Well. There is one in the form of "make signal handlers thread-safe or
> > defer non-threadsafe handlers".
>
> As long as there is only one thread that can invoke signal handlers,
> I don't see why you think they need to be "thread-safe".
>
> It's already the case that we either handle execution of a signal
> handler everywhere, or block delivery of the signal where we can't
> handle it, because in the Unix model a signal handler can execute
> anytime.
>
> I'd be more concerned about whether the proposed implementation accurately
> models signal mask processing (ie, temporary blocking of signal delivery).

On the Win32 project page:

http://momjian.postgresql.org/main/writings/pgsql/project/win32.html

I see for the CONNX driver code that handles signal masking:

/*
The sigsetmask system call replaces the set of blocked
signals totally with a new set specified in mask. Signals
are blocked if the corresponding bit in mask is a 1.
*/

int sigsetmask(int nNewMask)
{
int nPreviousMask = nGlobalSignalMask;
nGlobalSignalMask = nNewMask;
return nPreviousMask;
}

int sigmask(int nSignal)
{
return 1 << ((nSignal) - 1);
}

CONNX_signal_function CONNX_signal(int sig, CONNX_signal_function func)
{
CONNX_signal_function oldfunc;
oldfunc = CONNX_signal_array[sig];
CONNX_signal_array[sig] = func;
return oldfunc;
}

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Tom Lane 2003-12-17 15:35:52 Re: [HACKERS] [PATCHES] fork/exec patch
Previous Message Tom Lane 2003-12-17 14:56:49 Re: [HACKERS] [PATCHES] fork/exec patch