Andrew Dunstan wrote:
> Actually, I think I can live with the message - it's only called if initdb
> fails and is cleaning up.
> 1 second seems far too short - 3 seconds would be a minimum, I think.
OK, changed to 3 seconds in main CVS and Win32 branch.
> Also, looping forever on this seems dangerous. Shouldn't we just give up
> after some substantial number of tries to unlink the file? After all, on
> Unix we expect unlink to return immediately on failure, although we don't
> expect as many failures as this gets around :-)
Take a look at the unlink calls in the backend --- they don't check a
return status, so we have to succeed. We can change that, but right now
I am assuming it has to succeed.
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
In response to
pgsql-hackers-win32 by date
|Next:||From: Bruce Momjian||Date: 2003-10-10 03:31:45|
|Subject: Re: signals on windows|
|Previous:||From: Andrew Dunstan||Date: 2003-10-10 03:13:55|
|Subject: Re: lib problems|