Re: fix log_min_duration_statement logic error

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix log_min_duration_statement logic error
Date: 2003-09-29 18:51:55
Message-ID: 200309291851.h8TIptV03150@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Neil Conway <neilc(at)samurai(dot)com> writes:
> > I also don't particularly like the format of the log message (for one
> > thing, the "duration_statement" prefix in the log message shouldn't
> > include an underscore, it's not a variable or anything -- and the case
> > can be made that if we printed the duration because log_duration is set,
> > we don't need to print it again if the duration of the query exceeded
> > log_min_duration_statement), but I haven't changed it.
>
> I think there should be just one "duration: nnn" log entry, printed if
> either condition holds.

Done.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-09-29 18:53:19 Re: bug in clusterdb script
Previous Message Bruce Momjian 2003-09-29 18:51:40 Re: fix log_min_duration_statement logic error