Re: initdb failure (was Re: [GENERAL] sequence's plpgsql)

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Tim McAuley <mcauleyt(at)tcd(dot)ie>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: initdb failure (was Re: [GENERAL] sequence's plpgsql)
Date: 2003-09-26 18:12:39
Message-ID: 200309261812.h8QICdc21071@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers pgsql-jdbc

Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Tom Lane writes:
> >> so it appears that cygwin's "echo" generates a different newline style
> >> than what got put into sql_features.txt. A possible way to fix this is
> >> to put the "\." line into sql_features.txt, but maybe there's a cleaner
> >> answer. Peter, any thoughts?
>
> > There's no clean answer to this on Cygwin. This specific case is just a
> > little problem that we could solve locally, but in general you'll just end
> > up annoying people if you require them to use consistent line endings on
> > Cygwin.
>
> Yeah, I was wondering whether you wouldn't propose dropping the newline
> consistency check. I'm not very comfortable with that, but maybe we
> should. Bruce?

I posted on that a few minutes ago. Yea, we can drop it, but we risk
eating carraige returns as data values. I am not sure how consistently
we output literal carriage returns in old dumps, nor how many apps
produce on literal carriage returns in COPY. If we conditionally eat
them, we run the risk of discarding some of their data without warning.
Perhaps we can throw a warning rather than an error, and adjust initdb
to be consistent.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Andrew Dunstan 2003-09-26 18:20:33 Re: initdb failure (was Re: [GENERAL] sequence's plpgsql)
Previous Message Ned Lilly 2003-09-26 18:10:22 Metapa - PostgreSQL/Linux clustering for BI

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2003-09-26 18:20:33 Re: initdb failure (was Re: [GENERAL] sequence's plpgsql)
Previous Message Dann Corbit 2003-09-26 18:12:06 Re: [HACKERS] Threads vs Processes

Browse pgsql-jdbc by date

  From Date Subject
Next Message CRAIG GOLBY 2003-09-26 18:15:25 Re: Tomcat - PostgreSQL - Cannot load JDBC driverclass"null"
Previous Message Tom Lane 2003-09-26 18:08:10 Re: initdb failure (was Re: [GENERAL] sequence's plpgsql)