WIN32_CONSOLE usage

Peter Eisentraut wrote:
> Bruce Momjian writes:
>
> > The problem is that mbvalidate() has this code:
> >
> > if (GetVariableBool(pset.vars, "WIN32_CONSOLE"))
> > CharToOem(pwcs, pwcs);
> >
> > That's why I needed the #ifdef so it only tests from psql. This code
> > was just broken without that test, and because no one else has done
> > Win32 compiles since it was added, no one saw it.
>
> Interesting, considering that WIN32_CONSOLE isn't being set anywhere.
>
> Anyway, that code needs to be removed/fixed, for the mentioned reasons.

Yikes, I see no doc mention of it.

Here is the submission email:

> c) Problem: 8bit characters were displayed/interpreted wrong in psql
> This is due to the fact that the Win32 "console" uses a
> different encoding than the rest of the Windows system
> Solution: Introduced a new psql variable WIN32_CONSOLE
> When set with "\set WIN32_console", the function OemToChar()

I have CC'ed the author.

Is this a valid feature? Should I document it?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073