Skip site navigation (1) Skip section navigation (2)

Re: logging enhancements, minor code cleanup

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: logging enhancements, minor code cleanup
Date: 2003-08-11 21:06:16
Message-ID: 200308112106.h7BL6GH29577@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Andrew Dunstan wrote:
> 
> Answer = sane == 'fill buffer, don't overfill buffer' ? 'yes' : 'no';
> 
> :-)
> 
> Seriously, I will add comments when I submit the revised patch to 
> demonstrate the loop invariants etc. so nobody need get worried when 
> reading the code.
> 
> As for session end logging, I'm leaning in favor of a new 
> log_session_end or log_connection_end boolean, so that there is minimal 
> backwards compatibility impact. (Interestingly, that is actually the 
> only part of this stuff that is of any use to me right now).

Agreed.  A separate boolean is more self-documenting than 0/1/2.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2003-08-11 21:11:09
Subject: Re: logging enhancements, minor code cleanup
Previous:From: Peter EisentrautDate: 2003-08-11 15:27:07
Subject: Re: NLS: czech update

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group