Skip site navigation (1) Skip section navigation (2)

Re: ruleutils with pretty-print option

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>,pgsql-patches(at)postgresql(dot)org
Subject: Re: ruleutils with pretty-print option
Date: 2003-07-31 04:52:19
Message-ID: 200307310452.h6V4qJV12980@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
I didn't like the functions ending in _ext.  I renamed them to _pp for
pretty print.  Patch attached and applied.

---------------------------------------------------------------------------

Tom Lane wrote:
> Andreas Pflug <pgadmin(at)pse-consulting(dot)de> writes:
> > I recoded the stuff as Tom recommended, leaving the non-pretty version 
> > function names as they used to be, inventing new pg_get_XXXX_ext 
> > functions for the extended stuff, and pushing the code down into 
> > pg_get_XXXX_worker functions when needed. We now need the additional 
> > prototype include patch from builtins.h.
> 
> Applied with some editorializing.  In particular, I don't believe the
> original did the right thing with (a - (b - c)).
> 
> 			regards, tom lane
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2003-07-31 04:57:00
Subject: Re: ruleutils with pretty-print option
Previous:From: Bruce MomjianDate: 2003-07-31 04:48:35
Subject: Re: Spelling fix

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group