Re: ruleutils with pretty-print option

I am seeing the following regression failures from the patch to allow
pretty printing pg_get_*def functions.

Are these illustrating a problem with the function definition, or is it
happening because it is the first time we are calling the same function
with one and more than one parameter?

In fact, it seems you left the one-parameter versions of these functions
in pg_proc.h. I don't think that works. I think you need a wrapper
function for the one-parameter version that calls the two-parameter
version with a valid second parameter value. I can do the work if you
that is the proper way to handle it, or you can submit a new version.

Also, the patch doesn't apply cleanly to CVS anymore because Tom changed
the elogs in the adt directory. I can work around that.

I am attaching the regression failures, and an updated version of your
patch.

---------------------------------------------------------------------------

Andreas Pflug wrote:
> Bruce Momjian wrote:
>
> >Andreas, looks good, but I need a diff -c, context diff.
> >
> >
> >
> Hi Bruce,
> I intentionally only attached only non-context diffs because the patch
> is about 50 % size of the original file. Now, here's the same as context
> diff.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073