Re: nitpick consistency patch for pg_dump.c

This was the actual patch applied.

---------------------------------------------------------------------------

Andrew Dunstan wrote:
>
> trivial or not the patch was broken. *sigh*. it's been a long day.
>
> This patch will work.
>
> sorry
>
> andrew
>
> RCS file: /projects/cvsroot/pgsql-server/src/bin/pg_dump/pg_dump.c,v
> retrieving revision 1.335
> diff -c -w -r1.335 pg_dump.c
> *** pg_dump.c 25 Jun 2003 04:08:19 -0000 1.335
> --- pg_dump.c 18 Jul 2003 21:14:34 -0000
> ***************
> *** 3423,3433 ****
> attname = PQgetvalue(res, i, i_attname);
> atttypdefn = PQgetvalue(res, i, i_atttypdefn);
>
> ! if (i > 0)
> ! appendPQExpBuffer(q, ",\n\t");
> ! appendPQExpBuffer(q, "%s %s", fmtId(attname), atttypdefn);
> }
> ! appendPQExpBuffer(q, ");\n");
>
> /*
> * DROP must be fully qualified in case same name appears in
> --- 3423,3433 ----
> attname = PQgetvalue(res, i, i_attname);
> atttypdefn = PQgetvalue(res, i, i_atttypdefn);
>
> ! appendPQExpBuffer(q, "\n\t%s %s", fmtId(attname),
> atttypdefn);! if (i < ntups - 1)
> ! appendPQExpBuffer(q, ",");
> }
> ! appendPQExpBuffer(q, "\n);\n");
>
> /*
> * DROP must be fully qualified in case same name appears in
>
>
>
> >
> > This is a totally trivial patch for something that was a very minor nit
> > that annoyed me the other day while I was documenting my current
> > project. It makes pg_dump use the same layout for types as for tables,
> > by putting "\n\t" before the first field and "\n" before the final ");"
> >
> > Can't really justify this too much except to say I had an itch and I
> > scratched it ;-)
> >
>
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073