Skip site navigation (1) Skip section navigation (2)

Re: cleanup of cbrt() handling

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: cleanup of cbrt() handling
Date: 2003-05-25 14:06:11
Message-ID: 200305251406.h4PE6Be13500@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > This patch cleans up our static cbrt() implementation in float.c.
> 
> Looks like an improvement to me.

Yep, however, now that I look at the original code, and code that
shipped in 7.3:

	#ifndef HAVE_CBRT
	#define cbrt my_cbrt
	static double cbrt(double x);
	
	#else
	#if !defined(nextstep)
	extern double cbrt(double x);
	#endif
	#endif   /* HAVE_CBRT */

There is no my_cbrt() function, meaning anyone who didn't have cbrt
couldn't have even compiled 7.3, so I think we should just remove cbrt,
or mark it as UNUSED.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2003-05-25 14:57:11
Subject: Re: cleanup of cbrt() handling
Previous:From: Jan WieckDate: 2003-05-25 13:34:29
Subject: Re: updated win32 patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group