Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > This patch cleans up our static cbrt() implementation in float.c.
> Looks like an improvement to me.
Yep, however, now that I look at the original code, and code that
shipped in 7.3:
#define cbrt my_cbrt
static double cbrt(double x);
extern double cbrt(double x);
#endif /* HAVE_CBRT */
There is no my_cbrt() function, meaning anyone who didn't have cbrt
couldn't have even compiled 7.3, so I think we should just remove cbrt,
or mark it as UNUSED.
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
In response to
pgsql-patches by date
|Next:||From: Tom Lane||Date: 2003-05-25 14:57:11|
|Subject: Re: cleanup of cbrt() handling |
|Previous:||From: Jan Wieck||Date: 2003-05-25 13:34:29|
|Subject: Re: updated win32 patch|