Skip site navigation (1) Skip section navigation (2)

Re: updated win32 patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Jan Wieck <JanWieck(at)Yahoo(dot)com>
Cc: Neil Conway <neilc(at)samurai(dot)com>,PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: updated win32 patch
Date: 2003-05-24 05:03:28
Message-ID: 200305240503.h4O53SS02863@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Jan, have you committed this change to CVS yet?

---------------------------------------------------------------------------

Jan Wieck wrote:
> Neil Conway wrote:
>  and AFAICS the following function that the patch
> > adds isn't related to Win32 at all:
> > 
> > + /* For unknown parameter type during parse */
> > + void set_param_type(int t, Oid typid)
> > + {
> > +       if ((t > pfunc_num_args) || (t <= 0))
> > +               return;
> > +       param_type_info[t - 1] = typid;
> > + }
> 
> Good catch ...
> 
> That one is part of something that enables SPI preparation of plans with
> parameters of unknown datatype. The caller of SPI_prepare then will find
> the datatypes choosen by the parser/planner in the array passed in. Need
> to make that a separate one ...
> 
> 
> Jan
> 
> -- 
> #======================================================================#
> # It's easier to get forgiveness for being wrong than for being right. #
> # Let's break this rule - forgive me.                                  #
> #================================================== JanWieck(at)Yahoo(dot)com #
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-patches by date

Next:From: Peter EisentrautDate: 2003-05-24 11:57:48
Subject: Re: array support patch phase 1 patch
Previous:From: Bruce MomjianDate: 2003-05-24 04:45:37
Subject: Re: [SQL] noupcol code cleanup

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group