pygresql build/install problems: use setup.py?

From: george young <gry(at)ll(dot)mit(dot)edu>
To: pgsql-interfaces(at)postgresql(dot)org
Subject: pygresql build/install problems: use setup.py?
Date: 2003-05-14 19:24:32
Message-ID: 20030514152432.3097dd89.gry@ll.mit.edu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-interfaces pgsql-patches

[python 2.3a1 & 2.2, postgresql 7.3.2 & 7.2.1, x86 linux]

As you note from the above line, I'm wrangling multiple versions
of python and postgres[ql]. I use the PyGreSQL interface from the
postgres source dist. But I need to install PyGreSQL for other
than the default python. I know I could hack it by hand, but it
seems like there could be an optional arg to configure like:

./configure --with-python=python2.3

to specify a binary (and include files and lib install destination)
other than the default. Maybe it needs a separate option:

--python-include=/usr/local/include/python-2.3

I'm hoping some autoconf wiz will take this in hand -- auto* stuff
scares me...

I succeeded by fixing up setup.py:
vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
--- setup.py~ Tue Mar 19 08:21:14 2002
+++ setup.py Wed May 14 15:10:30 2003
@@ -30,8 +30,8 @@
optional_libs=[ 'libpqdll', 'wsock32', 'advapi32' ]
data_files = [ 'libpq.dll' ]
else:
- include_dirs=['/usr/include/pgsql']
- library_dirs=['usr/lib/pgsql']
+ include_dirs=['../../include','../libpq','/usr/include/pgsql']
+ library_dirs=['../libpq','/usr/lib/pgsql']
optional_libs=['pq']
data_files = []
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Isn't this the right thing to do? It should use the .. lib and include
dirs if they exist, since these are sure to be correct, as opposed
to hard coded /usr/lib/pgsql and /usr/include/pgsql which might
not exist until an install has been done, and worse, might be from
an older postgres version.

It seems like the makefiles should just run
$PYTHON setup.py build
and
$PYTHON setup.py install

since setup.py has a much better chance of installing in the right
directories, or am I missing something?

--
I cannot think why the whole bed of the ocean is
not one solid mass of oysters, so prolific they seem. Ah,
I am wandering! Strange how the brain controls the brain!
-- Sherlock Holmes in "The Dying Detective"

Responses

Browse pgsql-interfaces by date

  From Date Subject
Next Message Gerhard Häring 2003-05-15 08:28:00 Re: pygresql build/install problems: use setup.py?
Previous Message Stéphane Pinel 2003-05-14 17:29:50 Re: PQhost

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-05-15 03:37:05 Re: GUC and postgresql.conf docs
Previous Message Tom Lane 2003-05-14 03:35:20 Re: contrib/tablefunc bugfix